build(deps): pre-commit autoupdate#28
Merged
Merged
Conversation
updates: - [github.com/PyCQA/isort: 8.0.1 → 9.0.0a3](PyCQA/isort@8.0.1...9.0.0a3) - [github.com/commitizen-tools/commitizen: v4.13.10 → v4.15.0](commitizen-tools/commitizen@v4.13.10...v4.15.0)
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates pre-commit hook versions for isort and commitizen to newer releases, with no configuration changes besides the version pins, so review should focus on compatibility and any new behavior from these tools. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- isort 9.0.0a3 is an alpha release; consider whether you want to pin to a stable version or explicitly justify adopting an alpha in pre-commit to avoid unexpected breakages in formatting.
- isort 9 introduces some configuration and behavior changes compared to 8; it would be good to confirm that your existing isort configuration (e.g., in tox.ini/pyproject) still matches the new version’s option names and defaults.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- isort 9.0.0a3 is an alpha release; consider whether you want to pin to a stable version or explicitly justify adopting an alpha in pre-commit to avoid unexpected breakages in formatting.
- isort 9 introduces some configuration and behavior changes compared to 8; it would be good to confirm that your existing isort configuration (e.g., in tox.ini/pyproject) still matches the new version’s option names and defaults.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates:
Summary by Sourcery
Update pre-commit configuration to use newer versions of isort and commitizen.
Build: